Add fuzzing target to fuzz return type and parameters #301
+252
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
fuzz_parameters
branch
from
77945b3 to
fcb0862
Compare
ludfjig
force-pushed
the
fuzz_parameters
branch
2 times, most recently
from
b2d86f7 to
42f6f6c
Compare
dblnz
previously approved these changes
Mar 3, 2025
ludfjig
changed the title
ludfjig
force-pushed
the
fuzz_parameters
branch
12 times, most recently
from
e4443f9 to
2e2c893
Compare
I removed the fuzz check temporarily, once this merges let me know and I will add the 2 new ones |
simongdavies
previously approved these changes
Mar 5, 2025
guest and host function calls. Rename existing target to host_print. Move fuzz directory to root directory. Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
Signed-off-by: Ludvig Liljenberg <lliljenberg@microsoft.com>
marosset
approved these changes
Mar 5, 2025
danbugs
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
host_print.host_callfuzz target found, where RSP kept decreasing after each dispatch, and eventually caused an error. RSP should be reset every dispatch. The new logic resets RSP before each dispatch to the original RSP (which points to beginning of stack). I applied the new logic to all 3 drivers, even though the bug only manifested on KVM.In order to merge this PR, we need to remove
fuzz/fuzzingstatus check from branch protection, as this PR changes the name of that job tofuzz/fuzzing (guest_call)andfuzz/fuzzing (host_print)